On Wed, Oct 25, 2017 at 09:35:52AM +0200, Lukas Wunner wrote: > @Everyone, I've changed the function signature to take a struct uart_port > to be consistent with the other functions in serial_core.c. However this > means that the "dev" pointer in that struct needs to be populated before > uart_get_rs485_mode() can be called. Otherwise the kernel will oops on > probe, so a driver developer *will* realize there's a problem. I could > alternatively go back to what Uwe did and pass in a struct device > (instead of a struct device_node) plus a struct serial_rs485. This would > yield a higher rank on Rusty's API rating scheme. Let me know what you'd > prefer. Self-NAK on this patch, after a bit of waffling I think passing in a struct device plus a struct serial_rs485 makes more sense. Will respin in a bit. Thanks, Lukas -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
