Hi Hans,
> Commit 9834e586fa ("Bluetooth: btusb: Add workaround for Broadcom devices
> without product id") was added to deal with the BT part of the BCM4356A2
> on GPD pocket laptops having an usb vid:pid of 0000:0000.
>
> After another commit to add support for the BCM UART connected BT ACPI-id
> BCM2E7E used on the GPD win, it turns out that the BT on the GPD pocket is
> connected via both USB and UART. Adding support for the BCM2E7E ACPI-id
> causes it to switch to UART mode.
>
> The Windows shipped with the device is using it in UART mode and the
> presence of the BCM2E7E ACPI-id combined with the 0 USB vid:pid also
> indicates that the BT part was never meant to be used in USB mode.
>
> But not only is there no need to support the USB mode, supporting it
> actually is troublesome, because with the workaround to support the all 0
> USB vid:pid, BT will just work for end users, until we add support for
> the ACPI-id, after which users need to have userspace doing a btattach,
> which may be considered a regression.
>
> To avoid this regression when switching things over to UART mode as
> intended by the ACPI tables all along, this commit reverts the commit
> adding the workaround to support the all 0 USB vid:pid.
>
> This reverts commit 9834e586fa ("Bluetooth: btusb: Add workaround for
> Broadcom devices without product id").
>
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> ---
> drivers/bluetooth/btusb.c | 18 ------------------
> 1 file changed, 18 deletions(-)
can you send a series of patches, that first reverts this patch and then a patch adds the BCM2E7E id to the hci_bcm driver so that it will start working again.
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
