On Thu, Sep 21, 2017 at 05:18:13PM +0100, Martyn Welch wrote: > From: Romain Perier <romain.perier@xxxxxxxxxxxxx> > > The variable dma_is_rxing is currently set to 1 in imx_disable_rx_int(). > This is problematic as: > > - whilst imx_disable_rx_int() is currently always called before > start_rx_dma() this dependency isn't obvious. > - start_rx_dma() does error checking and might exit without > enabling DMA. Currently this will result in dma_is_rxing suggesting > that DMA is being used for recieving. > > To avoid these issues, move the setting of dma_is_rxing to > start_rx_dma() when appropriate. > > Signed-off-by: Romain Perier <romain.perier@xxxxxxxxxxxxx> > Signed-off-by: Martyn Welch <martyn.welch@xxxxxxxxxxxxxxx> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
