Hi Fabio, > -----Original Message----- > From: Fabio Estevam [mailto:festevam@xxxxxxxxx] > Sent: Monday, September 18, 2017 7:33 PM > To: gregkh@xxxxxxxxxxxxxxxxxxx > Cc: linux-serial@xxxxxxxxxxxxxxx; stefan@xxxxxxxx; A.s. Dong; Fabio > Estevam > Subject: [PATCH v2] serial: fsl_lpuart: Remove unused 'bd' variable > > From: Fabio Estevam <fabio.estevam@xxxxxxx> > > Since commit a6d7514b14a6 ("tty: serial: lpuart: add a more accurate baud > rate calculation method") the baud rate is now calculated inside the > lpuart32_serial_setbrg() function, so we no longer need to read the > UARTBAUD register inside lpuart32_set_termios(). > > The 'bd' variable can be simply removed. > > This fixes the following build warning with W=1: > > drivers/tty/serial/fsl_lpuart.c: In function 'lpuart32_set_termios': > drivers/tty/serial/fsl_lpuart.c:1652:32: warning: variable 'bd' set but > not used [-Wunused-but-set-variable] > > Fixes: a6d7514b14a6 ("tty: serial: lpuart: add a more accurate baud rate > calculation method") > Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxx> Thanks for catching this. Acked-by: Dong Aisheng <aisheng.dong@xxxxxxx> Regards Dong Aisheng > --- > Changes since v1: > - Improve commit log to explain why it is safe to remove the UARTBAUD > reading. > > drivers/tty/serial/fsl_lpuart.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/fsl_lpuart.c > b/drivers/tty/serial/fsl_lpuart.c index 849c1f9..63f99a0 100644 > --- a/drivers/tty/serial/fsl_lpuart.c > +++ b/drivers/tty/serial/fsl_lpuart.c > @@ -1649,12 +1649,11 @@ lpuart32_set_termios(struct uart_port *port, > struct ktermios *termios, { > struct lpuart_port *sport = container_of(port, struct lpuart_port, > port); > unsigned long flags; > - unsigned long ctrl, old_ctrl, bd, modem; > + unsigned long ctrl, old_ctrl, modem; > unsigned int baud; > unsigned int old_csize = old ? old->c_cflag & CSIZE : CS8; > > ctrl = old_ctrl = lpuart32_read(&sport->port, UARTCTRL); > - bd = lpuart32_read(&sport->port, UARTBAUD); > modem = lpuart32_read(&sport->port, UARTMODIR); > /* > * only support CS8 and CS7, and for CS7 must enable PE. > -- > 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
