Re: [tty:tty-testing 42/91] drivers/tty/serial/amba-pl011.c:2610:2: error: implicit declaration of function 'of_get_rs485_mode'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 28, 2017 at 05:53:28PM +0100, Ian Arkver wrote:
> On 28/08/17 17:14, Greg Kroah-Hartman wrote:
> > On Tue, Aug 29, 2017 at 12:06:21AM +0800, kbuild test robot wrote:
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
> > > head:   7f490ac24ed4b59ef8807c31e46a9afea1ca43c6
> > > commit: d5237f6946360a240ad70699642587a9dc95d254 [42/91] serial: amba-pl011: Add basic rs485 support
> > > config: arm-mxs_defconfig (attached as .config)
> > > compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
> > > reproduce:
> > >          wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > >          chmod +x ~/bin/make.cross
> > >          git checkout d5237f6946360a240ad70699642587a9dc95d254
> > >          # save the attached .config to linux build tree
> > >          make.cross ARCH=arm
> > > 
> > > All errors (new ones prefixed by >>):
> > > 
> > >     drivers/tty/serial/amba-pl011.c: In function 'pl011_setup_port':
> > > > > drivers/tty/serial/amba-pl011.c:2610:2: error: implicit declaration of function 'of_get_rs485_mode' [-Werror=implicit-function-declaration]
> > >       of_get_rs485_mode(dev->of_node, &uap->port.rs485);
> > >       ^~~~~~~~~~~~~~~~~
> > >     cc1: some warnings being treated as errors
> > 
> > Odd, this function isn't in my tree anywhere, I'll have to go drop this
> > patch :(
> 
> See Uwe's patch:
> [PATCH v4 3/9] serial: Add common rs485 device tree parsing function
> 
> I haven't seen a v5 of that and you weren't happy with v4 I think.

Ok, I'll have to drop this then, please be more explicit that your patch
depends on another one, I missed it this time :(

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux