On Mon, Aug 28, 2017 at 07:38:24PM +0300, Andy Shevchenko wrote: > On Tue, 2017-08-29 at 00:14 +0800, kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git > > tty-testing > > head: 7f490ac24ed4b59ef8807c31e46a9afea1ca43c6 > > commit: f564c1027c1faaf46f3d4191f37d97a1d9ee9022 [55/91] serial: core: > > remove unneeded irq_wake flag > > config: arm-lart_defconfig (attached as .config) > > compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 > > reproduce: > > wget https://raw.githubusercontent.com/01org/lkp-tests/master/ > > sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > git checkout f564c1027c1faaf46f3d4191f37d97a1d9ee9022 > > # save the attached .config to linux build tree > > make.cross ARCH=arm > > > > All errors (new ones prefixed by >>): > > > > drivers/tty/serial/serial_core.c: In function 'uart_resume_port': > > > > drivers/tty/serial/serial_core.c:2149:7: error: implicit > > > > declaration of function 'irqd_is_wakeup_set' [-Werror=implicit- > > > > function-declaration] > > > > if (irqd_is_wakeup_set(irq_get_irq_data((uport->irq)))) > > ^~~~~~~~~~~~~~~~~~ > > > > drivers/tty/serial/serial_core.c:2149:26: error: implicit > > > > declaration of function 'irq_get_irq_data' [-Werror=implicit- > > > > function-declaration] > > > > if (irqd_is_wakeup_set(irq_get_irq_data((uport->irq)))) > > ^~~~~~~~~~~~~~~~ > > cc1: some warnings being treated as errors > > > > vim +/irqd_is_wakeup_set +2149 drivers/tty/serial/serial_core.c > > Nice. > > So it means on x86 this is hidden. > > I _think_ it should be fixed by > > --- a/drivers/tty/serial/serial_core.c > +++ b/drivers/tty/serial/serial_core.c > @@ -37,7 +37,7 @@ > #include <linux/mutex.h> > #include <linux/pm_runtime.h> > > -#include <asm/irq.h> > +#include <linux/irq.h> > #include <linux/uaccess.h> > > /* > > Greg, would you like me to resend that patch with above change included > or just a fix up? Please resend it with the fix. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
