Re: [PATCH v2 3/3] serial: Fix port type numbering for TI DA8xx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2017-08-28 at 14:43 +0200, Greg Kroah-Hartman wrote:
> On Mon, Aug 28, 2017 at 02:33:19PM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Aug 22, 2017 at 04:58:22PM +0300, Andy Shevchenko wrote:
> > > The UAPI has a global list of unique numbers for different port
> > > types.
> > > The commit
> > > 	a2d6a987bfe4 ("serial: 8250: Add new port type for TI
> > > DA8xx/66AK2x")
> > > introduced a new port type and brought the collision with two
> > > other port
> > > types.
> > > 
> > > Reuse 95 for it instead.
> > 
> > I hate this "global userspace list", is there any good reason it is
> > used
> > or needed at all?  Why are we adding new ids here when no one uses
> > them?
> > Can we just delete the thing?

It's a good question. I dunno why developers adding them. As you noticed
in my case I deleted one from there (for Medfield).

Frankly I have no idea how this list is used outside of kernel and what
user space does with it. Perhaps it's due to legacy stuff like custom
dividers for 38400 (lately replaced by BOTHER) which effectively means
no need to add in modern world. Other than that I have no clue why we
might need it.

> Oh, this doesn't mean I don't like these patches, I do, and I've
> applied
> them now, thanks.

Thanks!

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux