On Wed, Jul 19, 2017 at 5:00 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
>> +{
>> + wait_event_interruptible_timeout(dev->rx_wq,
>> + dev->rx_state <= RX_FRAME_ERROR,
>> + HZ/2);
>
> I'd suggest to drop the interruptible. It can be done but it is usually
> not trivial to abort the operation gracefully when a signal comes in.
>
> Also, timeout is superfluous since you don't get the return value?
Be that as it may, I still want a timeout; wouldn't wait_event() block forever?
CU
Uli
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
