Hello, On (03/17/17 16:43), Aleksey Makarov wrote: [..] > +static void ensure_preferred_is_last(int i) > +{ > + int last; > + > + for (last = MAX_CMDLINECONSOLES - 1; > + last >= 0 && !console_cmdline[last].name[0]; > + last--) > + ; > + > + BUG_ON(last < 0); let's not panic(). a nitpick, console swap can be done as if (i != last) swap(console_cmdline[i], console_cmdline[last]); preferred_console = last; -ss -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html