Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 16, 2017 at 12:31:53PM +0300, Aleksey Makarov wrote:
> 
> 
> On 03/16/2017 10:11 AM, Jayachandran C. wrote:
> > Hi Greg,
> > 
> > On Tue, Mar 14, 2017 at 9:44 PM, Sudeep Holla <sudeep.holla@xxxxxxx> wrote:
> >>
> >>
> >> On 01/03/17 15:23, Aleksey Makarov wrote:
> >>> The original patch makes the condition always true, so it is wrong.
> >>>
> >>> It masks (but not fixes) the bug described in the commit message
> >>> but introduces a regression (no console is selected by SPCR)
> >>> in regular (no 'console=ttyAMA') case.
> >>>
> >>> s/||/&&/ would not fix the problem as the root cause was identified
> >>> incorrectly.
> >>>
> >>> This reverts commit aea9a80ba98a0c9b4de88850260e9fbdcc98360b.
> >>>
> >>
> >> Sorry for that, I will test your patches and respond to that. For this
> >> patch:
> >>
> >> Acked-by: Sudeep Holla <sudeep.holla@xxxxxxx>
> >>
> > 
> > This fixes a regression I see in v4.11-rc2
> > 
> > Tested-by: Jayachandran C <jnair@xxxxxxxxxxxxxxxxxx>
> > 
> > I don't see it in the tty/serial tree yet
> 
> It's commit 713b93f1b849 from tty-next branch of 
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
> 
> So it looks like it is scheduled for 4.12
> 
> Greg, this is a fix for regression.  Can it be applied to 4.11-rcX?

Yes, will do that now, thanks.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux