Re: [PATCH 09/10] serdev: add serdev_device_set_rts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

Sebastian Reichel, on jeu. 16 mars 2017 09:02:40 +0000, wrote:
> +void serdev_device_set_rts(struct serdev_device *serdev, bool enable)

Rather than defining a set_rts(enable), and then someone will want to
set DTR, and similarly, get_cts() + get_dsr()... Why not sticking to the
TTY ops, i.e. defining serdev_device_tiocmset(serdev, set, clear) and
serdev_device_tiocmget? That'd seem much more straightforward to me and
coherent with the TTY ops.

Samuel
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux