Re: [PATCH v6] uartlite: Adding a kernel parameter for the number of uartlites

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 21, 2017 at 03:38:42PM -0700, Sam Povilus wrote:
> The number of uartlites should be set by a kernel parameter instead of
> using a #define. This allows the user to set the number of uartlites
> using only kconfig and not modifying kernel source.
> 
> The uartlite is used by FPGAs that support a basically unlimited number
> of uarts so limiting it at 16 dosn't make sense as users might need more
> than that.
> 
> Signed-off-by: Sam Povilus <kernel.development@xxxxxxxx>
> ---
>  drivers/tty/serial/Kconfig    | 9 +++++++++
>  drivers/tty/serial/uartlite.c | 2 +-
>  2 files changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index e9cf5b67f1b7..435f1db2b614 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -630,6 +630,15 @@ config SERIAL_UARTLITE_CONSOLE
>  	  console (the system console is the device which receives all kernel
>  	  messages and warnings and which allows logins in single user mode).
>  
> +config SERIAL_UARTLITE_NR_UARTS
> +	int "Maximum number of uartlite serial ports"
> +	depends on SERIAL_UARTLITE
> +	range 1 256
> +	default 1
> +	help
> +	  Set this to the number of uartlites in your system, or the number
> +	  you think you might implement. 
> +
>  config SERIAL_SUNCORE
>  	bool
>  	depends on SPARC
> diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c
> index 817bb0d3f326..c9b8d702dadc 100644
> --- a/drivers/tty/serial/uartlite.c
> +++ b/drivers/tty/serial/uartlite.c
> @@ -28,7 +28,7 @@
>  #define ULITE_NAME		"ttyUL"
>  #define ULITE_MAJOR		204
>  #define ULITE_MINOR		187
> -#define ULITE_NR_UARTS		16
> +#define ULITE_NR_UARTS		CONFIG_SERIAL_UARTLITE_NR_UARTS
>  
>  /* ---------------------------------------------------------------------
>   * Register definitions

Always run checkpatch.pl on your patches so that you don't get an angry
kernel maintainer telling you that you need to run checkpatch.pl on your
patch...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux