Re: [PATCH 10/10] Bluetooth: add nokia driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marcel,

On Tue, Mar 07, 2017 at 10:20:27PM +0100, Marcel Holtmann wrote:
>> [...]
>>
>> - compatible: should contain "nokia,h4p-bluetooth" as well as one of the following:
>> * "brcm,bcm2048-nokia"
>> * "ti,wl1271-blueooth-nokia”
> 
> I never liked the term “h4p”. It is fundamentally just
> “bluetooth”.

It's not me, that came up with the term, Nokia called their protocol
H4+ (for DT people not familiar with bluetooth - the standard
bluetooth UART protocol is named H4). I agree, that H4+ is
ambiguous, but with the "nokia," prefix it should be clear what
protocol is meant. I don't really mind, though. We can also just
list the individual chips and add all compatible strings to the
driver.

FWIW I remove the term from the driver leaving only a single
instance in the header ("AKA H4+").

> What are our plans for Broadcom, Intel etc. Bluetooth UARTs?

I think drivers, that need extra resources (like GPIOs) can switch to
serdev exclusively. The kernel needs ACPI/DT/boardcode data for those
devices anyways.

Iirc Rob is working on serdev patches for Broadcom and TI BT, so he may
provide more information.

-- Sebastian

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux