Re: [PATCH 2/2] serial: imx: Fix the CTS_B polarity in RS485 mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Fabio,

On Mon, Feb 20, 2017 at 10:42:56AM -0300, Fabio Estevam wrote:
> Hi Clemens,
> 
> On Mon, Feb 20, 2017 at 10:07 AM, Clemens Gruber
> <clemens.gruber@xxxxxxxxxxxx> wrote:
> the
> > Then, setting SER_RS485_RTS_ON_SEND and clearing
> > SER_RS485_RTS_AFTER_SEND would lead to:
> > CTS_B being logic low during send
> > CTS_B being logic high before and after send
> >
> > So, if you want CTS_B to be driven high during send, you'd have to clear
> > SER_RS485_RTS_ON_SEND and set SER_RS485_RTS_AFTER_SEND.
> 
> In this case we break userspace applications that follow the API as
> described in Documentation/serial/serial-rs485.txt:
> 
> /* Set logical level for RTS pin equal to 1 when sending: */
> rs485conf.flags |= SER_RS485_RTS_ON_SEND;

I am sorry, I just noticed that I did not have the 1st patch of your
series "[PATCH 1/2] serial: imx: Fix the RTS GPIO polarity" in my tree.

So, looks good with **both** patches applied! ;)

In my case, I'll set SER_RS485_RTS_AFTER_SEND and clear
SER_RS485_RTS_ON_SEND to get logic low on the CTS_B pin during transmit.

Thanks,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux