On Mon, Feb 13, 2017 at 08:38:02PM -0700, Sam Povilus wrote: > The number of uartlites should be set by a kernel parameter instead of > using a #define. Why? > This allows the user to set the number of uartlites without creating a > custom kernel. No it doesn't, they still have to rebuild the kernel. Who needs or wants this? What hardware wants to change this value? > > Signed-off-by: Sam Povilus <kernel.development@xxxxxxxx> > --- > drivers/tty/serial/Kconfig | 5 +++++ > drivers/tty/serial/uartlite.c | 2 +- > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig > index e9cf5b67f1b7..96d6f149b221 100644 > --- a/drivers/tty/serial/Kconfig > +++ b/drivers/tty/serial/Kconfig > @@ -630,6 +630,11 @@ config SERIAL_UARTLITE_CONSOLE > console (the system console is the device which receives all kernel > messages and warnings and which allows logins in single user mode). > > +config SERIAL_UARTLITE_NR_UARTS > + int "Maximum number of uartlite serial ports" > + depends on SERIAL_UARTLITE > + default "16" > + All Kconfig items need help text. Also, this is v3, right? Please always number your patches. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
