On Mon, Feb 13, 2017 at 06:26:32PM -0700, sam povilus wrote: > Well that was terribly embarrassing. Why is that here in the changelog text? And look at the subject, does it match the style of other commits in this subsystem? > The number of uartlites should be set by a kernel parameter instead of using a #define That says what this does, but not _why_ you are doing this. Also, please always wrap your text at 72 columns, like your editor tried to get you to do when you committed this :) > > Signed-off-by: Sam Povilus <kernel.development@xxxxxxxx> > --- > drivers/tty/serial/Kconfig | 5 +++++ > drivers/tty/serial/uartlite.c | 2 +- > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig > index e9cf5b67f1b7..96d6f149b221 100644 > --- a/drivers/tty/serial/Kconfig > +++ b/drivers/tty/serial/Kconfig > @@ -630,6 +630,11 @@ config SERIAL_UARTLITE_CONSOLE > console (the system console is the device which receives all kernel > messages and warnings and which allows logins in single user mode). > > +config SERIAL_UARTLITE_NR_UARTS > + int "Maximum number of uartlite serial ports" > + depends on SERIAL_UARTLITE > + default "16" > + > config SERIAL_SUNCORE > bool > depends on SPARC > diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c > index 817bb0d3f326..c9b8d702dadc 100644 > --- a/drivers/tty/serial/uartlite.c > +++ b/drivers/tty/serial/uartlite.c > @@ -28,7 +28,7 @@ > #define ULITE_NAME "ttyUL" > #define ULITE_MAJOR 204 > #define ULITE_MINOR 187 > -#define ULITE_NR_UARTS 16 > +#define ULITE_NR_UARTS CONFIG_SERIAL_UARTLITE_NR_UARTS > > /* --------------------------------------------------------------------- > * Register definitions Your tabs were eaten and spaces were spit out, making this patch impossible to apply :( Please fix this all up, and do a v3 of the patch, and document what changed (again, Documentation/SubmittingPatches says how to do that.) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
