Re: [RFC] serial: imx: Fix the polarity of RTS GPIO pin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Uwe,

On Wed, Jan 25, 2017 at 4:59 AM, Uwe Kleine-König
<u.kleine-koenig@xxxxxxxxxxxxxx> wrote:

> Right, that looks fishy. It was introduced in 58362d5be3521 which keeps
> the behaviour of the hw rts. I.e. if SER_RS485_RTS_AFTER_SEND is set it
> clears UCR2_CTS. This means "The CTS pin is high (inactive)". This is
> wrong, too, isn't it? So the wrong commit is 17b8f2a3fdca and
> 58362d5be3521 only consistently expanded it.

What about this?
http://pastebin.com/mDi2erfQ

With this patch I can get rs485 in half-duplex mode to work correctly with
rts-gpios = <&gpio6 2 GPIO_ACTIVE_HIGH>;

I do not have a board that uses the native CTS pin connected to the
TXEN pin of a RS485 transceiver, but I have enabled another UART that
exposes CTS pin and I can see it going to 1 during transmission and 0
after that.
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux