Hi Tim, On Tue, Jan 24, 2017 at 9:00 PM, Tim Harvey <tharvey@xxxxxxxxxxxxx> wrote: > Fabio, > > I also have boards that uses a GPIO as an active-high enable to an > RS485 transceiver. In my device-trees I define as 'rts-gpios = <&gpio7 > 1 GPIO_ACTIVE_HIGH>'. I do find that the polarity is inverted on > master and your patch does flip the polarity. However, I share your > concern that this may not be the right way to fix it. > > my understanding is that the TIOCSRS485 ioctl should have 'flags = > SER_RS485_ENABLED | SER_RS485_RTS_ON_SEND' to assert RTS on transmit. > The thing I find confusing is that in imx_start_tx the driver calls > imx_port_rts_inactive if SER_RS485_ENABLED and in imx_stop_tx the > driver calls imx_port_rts_active. To me that is what seems inverted, > not the implementation of those functions. Agreed. I will send a formal patch tomorrow. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
