On Friday 20 January 2017 10:25 PM, Andy Shevchenko wrote:
On Fri, Jan 20, 2017 at 12:23 AM, Sudip Mukherjee
<sudipm.mukherjee@xxxxxxxxx> wrote:
From: Sudip Mukherjee <sudip.mukherjee@xxxxxxxxxxxxxxx>
Add the serial driver for the Exar chips. And also register the
platform device for the GPIO provided by the Exar chips.
Thanks, this is indeed much cleaner that v6 I saw couple of weeks before!
Andy,
Having 3 setup hooks and assigning everything there was becoming too
complicated for me to follow, so i left it as it is. Though some more
parts from the board setup has been removed. uart_offset has been
completely removed.
Yes, what about baudrate?
I will check later, but for me it seems other way, i.e. simpler to
have just 3 setup functions in a row than one is lurking somewhere
with allocation et al.
<snip>
+ CONNECT_DEVICE(XR17C154, UART_4_485),
+ CONNECT_DEVICE(XR17C158, UART_8_485),
Perhaps it takes few LOC more, but having same defined struct here
with dedicated ->setup() looks cleaner to me.
I think now I understand the 3 different setup functions. Let me try v11
(hopefully the last one).
Regards
Sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
