On Tue, 2016-11-15 at 20:57 +0200, Andy Shevchenko wrote: > On Mon, 2016-11-14 at 16:58 -0800, Tony Lindgren wrote: > > * Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> [161114 > > 08:32]: > > > On Mon, 2016-11-14 at 11:54 +0100, Sebastian Andrzej Siewior > > > wrote: > > > > On 2016-11-10 15:58:54 [+0200], Andy Shevchenko wrote: > > We have a separate always on interrupt controller now. That uses > > Linux generic wakeirq support and just calls the PM runtime resume > > on interrupt if the UART is (runtime) suspended. So Andy's patch > > works > > for me as tested on omap3 with the wakeirq. > > Thanks! > > > > > > In the "threaded" handler you check whether or not the device is > > > > suspended. Can or can not the timer fire after the check? > > > > > > Nothing prevents it to fire after the check. > > > > > > Basically it means we need synchronization between IRQ handler and > > > ->runtime_suspend() hook. > > > > > > There is a few paragraphs at the end of > > > Documentation/power/runtime_pm.txt related to the topic. > > > > OK > > So, for now on I would leave this patch as is. Might be add another > comment that it's potentially racy in case of threadirqs enabled. > Let's > solve problems when they come. Guys, I would resend this patch as is for now. If you have any objection s, let me know! I'm also open to suggestions how to improve it (always threaded IRQ case). -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
