Re: [PATCH v1 2/3] serial: 8250_mid: enable MSI on Denverton

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 02, 2017 at 12:44:47PM +0200, Andy Shevchenko wrote:
> On Mon, 2017-01-02 at 12:40 +0200, Heikki Krogerus wrote:
> > On Mon, Jan 02, 2017 at 11:23:42AM +0200, Andy Shevchenko wrote:
> > > Enable MSI type of interrupt if PCI BIOS supports it.
> > > 
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > > ---
> > >  drivers/tty/serial/8250/8250_mid.c | 8 +++++++-
> > >  1 file changed, 7 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/tty/serial/8250/8250_mid.c
> > > b/drivers/tty/serial/8250/8250_mid.c
> > > index 6730d9eef81e..85011c9ac0ee 100644
> > > --- a/drivers/tty/serial/8250/8250_mid.c
> > > +++ b/drivers/tty/serial/8250/8250_mid.c
> > > @@ -164,8 +164,14 @@ static int dnv_setup(struct mid8250 *mid,
> > > struct uart_port *p)
> > >  	unsigned int bar = FL_GET_BASE(mid->board->flags);
> > >  	int ret;
> > >  
> > > +	ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
> > > +	if (ret < 0)
> > > +		return ret;
> > 
> > pci_free_irq_vectors() in dnv_exit()?
> 
> Seems everyone stumble over pcim_()* stuff. pcim_release() will take
> care of this.

OK. In that case, FWIW for the whole series:

Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>


Thanks,

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux