On Fri, 2016-12-16 at 11:52 +0100, Jean Delvare wrote:
> Hiding tristate options with "if EXPERT" is usually not a good idea.
> You can decide that the driver should be included by default, but you
> don't know if the user wants it built-in or as a module. Hiding the
> option prevents the user from making that decision.
>
> This is even more problematic when said option selects other options.
> You end up with several device drivers forcibly built into the kernel.
>
> In this specific case, drivers 8250_mid, virt-dma, hsu_dma and
> hsu_dma_pci end up being built-in as soon as SERIAL_8250=y. It is
> very common for distribution kernels to build the subsystem core code
> into the kernel, because almost everybody will need it, but build all
> the drivers as modules. This should be made possible.
>
> So drop the "if EXPERT" and make SERIAL_8250_MID visible. The right
> way to avoid annoying people who couldn't care less about this option
> is to make it depend on X86_INTEL_MID. There may be no technical
> dependency between these two options, but in practice, either people
> want support for a platform, or they don't.
>
Sorry, but similar comments here.
> Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
> Fixes: 1fc969c75986 ("serial: 8250_mid: make module available only on
> X86")
> Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Jiri Slaby <jslaby@xxxxxxxx>
> ---
> drivers/tty/serial/8250/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> --- linux-4.9.orig/drivers/tty/serial/8250/Kconfig 2016-12-16
> 11:10:53.522659445 +0100
> +++ linux-4.9/drivers/tty/serial/8250/Kconfig 2016-12-16
> 11:25:08.439835588 +0100
> @@ -417,12 +417,12 @@ config SERIAL_8250_LPSS
> - Intel Quark X1000 SoC
>
> config SERIAL_8250_MID
> - tristate "Support for serial ports on Intel MID platforms" if
> EXPERT
> + tristate "Support for serial ports on Intel MID platforms"
> default SERIAL_8250
> depends on SERIAL_8250 && PCI
> - depends on X86 || COMPILE_TEST
> + depends on X86_INTEL_MID || COMPILE_TEST
No.
> select HSU_DMA if SERIAL_8250_DMA
> - select HSU_DMA_PCI if (HSU_DMA && X86_INTEL_MID)
> + select HSU_DMA_PCI if SERIAL_8250_DMA
No.
You missed Denverton case.
> select RATIONAL
> help
> Selecting this option will enable handling of the extra
> features
>
--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
