On Wed, Nov 23, 2016 at 11:08:19AM +0100, Greg Kroah-Hartman wrote: > On Wed, Nov 23, 2016 at 11:01:03AM +0100, Sascha Hauer wrote: > > With this patch the serial core provides LED triggers for RX and TX. > > > > As the serial core layer does not know when the hardware actually sends > > or receives characters, this needs help from the UART drivers. The > > LED triggers are registered in uart_add_led_triggers() called from > > the UART drivers which want to support LED triggers. All the driver > > has to do then is to call uart_led_trigger_[tx|rx] to indicate > > activity. BTW last time LED triggers were discussed (https://patchwork.kernel.org/patch/9212885/) You and Arnd mandated the triggers should be implemented in the tty layer. By tty layer did you really mean the tty layer or did you mean serial_core? We could implement it in the tty layer, but tty doesn't know when the characters are actually sent. There could be arbitrary time passing between a tty_operations->put_char and the character being on the wire. Also I am not sure if we want to have LED triggers for each and every tty in the system Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
