On Mon, Nov 07, 2016 at 04:42:53PM +0100, Simon Horman wrote: > From: Takatoshi Akiyama <takatoshi.akiyama.kj@xxxxxxxxxxxxxxxxxxxxxxxx> > > The SCSCR register access in sci_break_ctl() is not locked. > > sci_start_tx() and sci_set_termios() changes the SCSCR register, > but does not lock sci_port. Maybe naive question: Shouldn't stop_tx and/or (start|stop)_rx be protected, too? They change SCSCR as well? > Therefore, this patch adds lock during register access. > > Also, remove the log output that leads to a double lock. > > Signed-off-by: Takatoshi Akiyama <takatoshi.akiyama.kj@xxxxxxxxxxxxxxxxxxxxxxxx> > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> > Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature