Re: [PATCH v2 2/2] serial: 8250_dw: Add support for IrDA SIR mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Are you sure it is a good idea to have 18 addresses in Cc list?

When you use automatic filing of Cc list, reduce it by, for example,
percentage of changes like --min-percent 67.

As an example, I left only few which I suppose are still interested in
this patch.

On Fri, 2016-10-28 at 18:04 +0100, Ed Blake wrote:
> Add a set_ldisc function to enable/disable IrDA SIR mode according to
> the new line discipline, if IrDA SIR mode is supported by the hardware
> configuration.

And one comment below.

@@ -357,6 +377,9 @@ static void dw8250_setup_port(struct uart_port *p)
>  
>  	if (reg & DW_UART_CPR_AFCE_MODE)
>  		up->capabilities |= UART_CAP_AFE;
> +
> +	if (reg & DW_UART_CPR_SIR_MODE)
> +		data->sir_mode_supported = true;

It might be common for many UARTs, would it be better to have
UART_CAP_IRDA? 


-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux