Re: [PATCH 2/2] tty/serial/8250: use mctrl_gpio helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2016-10-20 at 11:34 +0200, yegorslists@xxxxxxxxxxxxxx wrote:
> From: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx>
> 
> This patch permits the usage for GPIOs to control
> the CTS/RTS/DTR/DSR/DCD/RI signals.
> 
> Signed-off-by: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx>


> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

No way.

> --- a/Documentation/devicetree/bindings/serial/8250.txt
> +++ b/Documentation/devicetree/bindings/serial/8250.txt
> @@ -44,6 +44,9 @@ Optional properties:
>    property.
>  - tx-threshold: Specify the TX FIFO low water indication for parts
> with
>    programmable TX FIFO thresholds.
> +- {rts,cts,dtr,dsr,rng,dcd}-gpios: specify a GPIO for
> RTS/CTS/DTR/DSR/RI/DCD

It would be better to describe one per line.
Imagine if somebody goes to grep for 'rts-gpios' usage will they get it
here?

> +  line respectively. It will use specified GPIO instead of the
> peripheral
> +  function pin for the UART feature. If unsure, don't specify this
> property.

I think the bindings should go in a separate patch.

>  
>  Note:
>  * fsl,ns16550:
> @@ -65,3 +68,19 @@ Example:
>  		interrupts = <10>;
>  		reg-shift = <2>;
>  	};
> +
> +Example for OMAP UART using GPIO-based modem control signals:
> +
> +	uart4: serial@49042000 {
> +		compatible = "ti,omap3-uart";
> +		reg = <0x49042000 0x400>;
> +		interrupts = <80>;
> +		ti,hwmods = "uart4";
> +		clock-frequency = <48000000>;
> +		cts-gpios = <&gpio3 5 GPIO_ACTIVE_LOW>;
> +		rts-gpios = <&gpio3 6 GPIO_ACTIVE_LOW>;
> +		dtr-gpios = <&gpio1 12 GPIO_ACTIVE_LOW>;
> +		dsr-gpios = <&gpio1 13 GPIO_ACTIVE_LOW>;
> +		dcd-gpios = <&gpio1 14 GPIO_ACTIVE_LOW>;
> +		rng-gpios = <&gpio1 15 GPIO_ACTIVE_LOW>;
> +	};


-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux