On Thu, 2016-09-15 at 12:44 +0200, Greg Kroah-Hartman wrote: > On Wed, Sep 07, 2016 at 02:55:38PM +0300, Andy Shevchenko wrote: > > > > Regroup and sort alphabetically Kconfig and Makefile. > > why? When someone wants to add driver or split huge piece of 8250_pci into separate module it's a bit hard to detect where to place new lines in files under question. > > > > > Kconfig is regroupped to contain: > > > > 1) basic options, including generic drivers (PNP, PCI, OF, CS) > > 2) multi-port cards > > 3a) miscellaneous options > > 3b) drivers as a quirks of 8250_port.c > > 3c) optional drivers > > > > Makefile is regroupped to contain: > > 1) 8250 driver > > 2) 8250_base set > > 3) basic options, generic drivers > > 4) multi-port card drivers > > 5) optional drivers > > > > The names are sorted alphabetically inside each of the group. > > While keeping things orderly is nice, I don't really see a benefit of > this patch. It would only cause backports more problems, right? You may say the same about many clean up patches like replacing printk(LEVEL) by pr_lvl(). I think it can be done once and keep supporting this order will be much easier in the future. 4.9 is a good candidate (since it will be LTS, AFAIK). -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
