On Wed, 2016-04-27 at 16:48 +0300, Andy Shevchenko wrote: > Intel Quark has DesignWare UART. Move the code from 8250_pci to > 8250_lpss. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > --- > drivers/tty/serial/8250/8250_lpss.c | 11 +++++++++++ > drivers/tty/serial/8250/8250_pci.c | 15 +-------------- > 2 files changed, 12 insertions(+), 14 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_lpss.c > b/drivers/tty/serial/8250/8250_lpss.c > index 3112e8b..af34189 100644 > --- a/drivers/tty/serial/8250/8250_lpss.c > +++ b/drivers/tty/serial/8250/8250_lpss.c Andy, If you are going to start removing working PCI devices from the PCI config table in favour of a shim in SERIAL_8250_LPSS then the very minimum should be some sort of dependency link between SERIAL_8250_LPSS and CONFIG_SERIAL_8250_PCI in kconfig. A user could reasonably read the QRK datasheet - switch on CONFIG_SERIAL_8250_PCI and then wonder why no console output happened on boot. S/he shouldn't have to know that devices were moved from the PCI driver to an LPSS shim driver or that the 8250_lpss driver now needs to be selected instead of the intuitively correct 8250_pci driver. So assuming you agree with that (profound and sublime) logic and will make that dependency linkage then this is fine for me from a QRK POV. Reviewed-by: Bryan O'Donoghue <pure.logic@xxxxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
