Re: [PATCH v2, RESEND] serial-uartlite: Constify uartlite_be/uartlite_le

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 20, 2016 at 10:23:44AM +0200, Maarten Brock wrote:
> ----- Original Message -----
> From: Greg KH [mailto:greg@xxxxxxxxx]
> To: Maarten Brock [mailto:m.brock@xxxxxxxxxxxxx]
> Cc: linux-serial@xxxxxxxxxxxxxxx
> Sent: Tue, 19 Apr 2016 22:08:17 +0200
> Subject: Re: [PATCH v2, RESEND] serial-uartlite: Constify uartlite_be/uartlite_le
> 
> 
> > On Tue, Apr 19, 2016 at 11:51:23AM +0200, Maarten Brock wrote:
> > > Made uartlite_be and uartlite_le constants.
> > > Fixup warnings of v1.
> > 
> > What does this last line mean in a changelog?
> > 
> > confused,
> > 
> > greg k-h
> 
> It means that this second version of this patch now has some extra casts to
> suppress the warnings that version 1 created. I added it to emphasize that it
> is not identical to the previous version that caused so much needless
> discussion. If you don't like it, feel free to remove it.

I should never have to edit a changelog text to apply a patch, please
resend it without it.  Normally version information goes below the ---
line so that git does not pick it up as it doesn't matter for the
changelog entry.

So please fix it up and resend.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux