On Fri, 15 Apr 2016 15:31:30 -0700 Peter Hurley <peter@xxxxxxxxxxxxxxxxxx> wrote: > The only caller of the uart driver's break_ctl() method is > uart_break_ctl(), which is serial core's proxy tty driver break_ctl() > method. uart_break_ctl() claims the struct tty_port::mutex to prevent > concurrent tiocmset(). > > Thus, the uart driver's break_ctl() method won't be called in atomic > context. I'm missing something here. I can fully believe that uart_break_ctl() won't call break_ctl() in atomic context, but the fact that it holds a mutex in no way guarantees that. If uart_break_ctl() makes that promise we should just say so. Sorry to be obnoxious, but I'd rather not put confusing stuff into the changelog if possible. jon -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
