Re: [PATCH 0/6] serial: 8250: dma fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/12/2016 08:48 AM, Sebastian Andrzej Siewior wrote:
> On 04/10/2016 07:14 AM, Peter Hurley wrote:
>> Hi Greg, et. al.
> 
> Hi Peter,
> 
>> This series aims to keep 8250 dma and the omap8250 variant from
>> diverging further, in the hopes that at some point the implementations
>> will converge.
> 
> I've been told that omap's implementation is too different and I should
> stay out of the common code.

I know, but I don't completely agree.


> Nice to see that that will be brought together as far as possible.

I think more can be done.



>> A similar check is added for the tx chanenl. Soon I expect to add pause
>> check to tx channel as well, as I believe it will be required to
>> implement XON/XOFF transmit *which is completely missing* - with dma
>> enabled the x_char is never transmitted.
> 
> Sending XON/XOFF after TX completed would also be away. Pausing the
> transfer will lower the chance of an overrun. This requirement can't be
> fulfilled by OMAP-DMA, right?

Honestly, for me it's whatever way ends up being the intersection
of effective and clean and minimal.


--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux