Re: [PATCH 2/6] serial: 8250: Validate dmaengine tx chan meets requirements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/10/2016 07:14 AM, Peter Hurley wrote:
> --- a/drivers/tty/serial/8250/8250_dma.c
> +++ b/drivers/tty/serial/8250/8250_dma.c
> @@ -201,6 +201,15 @@ int serial8250_request_dma(struct uart_8250_port *p)
>  		goto release_rx;
>  	}
>  
> +	/* 8250 tx dma requires dmaengine driver to support terminate */
> +	ret = dma_get_slave_caps(dma->txchan, &caps);
> +	if (ret)
> +		goto err;
> +	if (!caps.cmd_terminate) {
> +		ret = -EINVAL;
> +		goto err;
> +	}

So you want to be able to terminate the TX transfer instead of waiting
for its completion because with flow control you could wait for ever?

> +
>  	dmaengine_slave_config(dma->txchan, &dma->txconf);
>  
>  	/* RX buffer */

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux