Re: Driver Max310x called more than once

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Четверг,  7 апреля 2016, 12:10 +03:00 от Micka <mickamusset@xxxxxxxxx>:
> 
>  Hi Alexander did you had the opportunity to look at the code ? 

Hello.

As first step, please eliminate any "printk" from the code or if it really necessary
let's use dev_dbg() equivalent.
Then please add some comments to changed lines.

Thanks.

> Le lun. 4 avr. 2016 15:22, Alexander Shiyan < shc_work@xxxxxxx > a écrit :
> >> Понедельник,  4 апреля 2016, 15:52 +03:00 от " gregkh@xxxxxxxxxxxxxxxxxxx " < gregkh@xxxxxxxxxxxxxxxxxxx >:
> >>
> >> On Mon, Apr 04, 2016 at 09:46:56AM +0200, Micka wrote:
> >> > Hello,
> >> >
> >> > You will find there the diff of the modifications that I made:
> >>
> >> Your patch is corrupted with whitespace all messed up :(
> >>
> >> > ( the idea is to call once the function uart_register_driver ) . I can
> >> > see without problem the two uart on the /dev/ folder.
> >> > The first ttyMAX0 work well, but the ttyMAX1 don't give any spi signal.
> >> > If I'm using the second uart alone, it works well. So it's not a
> >> > problem of electronics, but more about the driver handling two max310x
> >> > ( max3107 ) .
> >> >
> >> > >From 5a672a9a33f31523611870f33fe74b1ed385916e Mon Sep 17 00:00:00 2001
> >> > From: michael musset < mickamusset@xxxxxxxxx >
> >> > Date: Mon, 4 Apr 2016 09:37:58 +0200
> >> > Subject: [PATCH] max310x multi device
> >> >
> >> > Signed-off-by: michael musset < mickamusset@xxxxxxxxx >
> >>
> >> What is the goal of your patch?  You don't describe it here, in the
> >> changelog area, as is required for it to be accepted.
> >
> >Please await to apply this util i will undertstand this patch. Thanks!

---

��.n��������+%������w��{.n�����{��ǫ����{ay�ʇڙ���f���h������_�(�階�ݢj"��������G����?���&��




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux