Re: [PATCH v1 4/5] serial: 8250_mid: make module available only on X86

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2016-03-23 at 09:56 +0200, Heikki Krogerus wrote:
> On Tue, Mar 22, 2016 at 04:11:09PM +0200, Andy Shevchenko wrote:
> > 
> > There is no reason to compile module on non-X86 platforms, though
> > COMPILE_TEST
> > is provided for sake of what it does.
> > 
> > While here, set default to SERIAL_8250 that user doesn't need an
> > explicit
> > option to be set.
> If we default to that, then let's also add "if EXPERT" while at it.

Yes, we may do this as well.
Greg, would you like me to resend series with 

- tristate "Support for serial ports on Intel MID platforms" 
+ tristate "Support for serial ports on Intel MID platforms" if EXPERT

included?

> 
> 
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > ---
> >  drivers/tty/serial/8250/Kconfig | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/tty/serial/8250/Kconfig
> > b/drivers/tty/serial/8250/Kconfig
> > index b03cb517..2d62c5a 100644
> > --- a/drivers/tty/serial/8250/Kconfig
> > +++ b/drivers/tty/serial/8250/Kconfig
> > @@ -369,7 +369,9 @@ config SERIAL_8250_INGENIC
> >  
> >  config SERIAL_8250_MID
> >  	tristate "Support for serial ports on Intel MID platforms"
> > +	default SERIAL_8250
> >  	depends on SERIAL_8250 && PCI
> > +	depends on X86 || COMPILE_TEST
> >  	select HSU_DMA if SERIAL_8250_DMA
> >  	select HSU_DMA_PCI if (HSU_DMA && X86_INTEL_MID)
> >  	select RATIONAL
> Thanks,
> 

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux