Re: [PATCH] tty: amba-pl011: Use 32-bit accesses for SBSA UART

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Greg Kroah-Hartman wrote:
On Wed, Mar 30, 2016 at 12:01:56PM -0500, Timur Tabi wrote:
Greg Kroah-Hartman wrote:
If this isn't a bug fix or regression fix, it's not ok for 4.6-final, it
will have to wait for 4.7-rc1.

It fixes a problem on our platform (QDF2432).  Without this patch, we can't
use the PL011 at all.

Did it ever work before?  Or is this new functionality?

No, it never worked before, so it's not a regression. I guess it all depends on how you define "fix". The driver loads and attempts to use the hardware, but it fails without this patch. The system locks up completely (I guess it throws an unhandled exception or something).

I guess if you take a very limited definition of "fix", then this isn't a fix. I can understand if you didn't want to take it for 4.6-rc7 or something, but for 4.6-rc2, I don't think it's inappropriate.

That's my two cents. We'd like to see it in 4.6-rc2, but the decision is yours.

--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum, a Linux Foundation collaborative project.
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux