Hi Jean, On 03/08/2016 05:30 AM, Jean Delvare wrote: > Kconfig option SERIAL_8250_RT288X seems to be only relevant on a > limited number of platforms, so do not present it on other > architectures, unless build-testing. > > Signed-off-by: Jean Delvare <jdelvare@xxxxxxx> > Acked-by: John Crispin <blogic@xxxxxxxxxxx> > Cc: Mans Rullgard <mans@xxxxxxxxx> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Cc: Jiri Slaby <jslaby@xxxxxxxx> > --- > Changes since v1: > * Add ARCH_TANGO to the list of platforms, as Måns Rullgård tells me > it has this hardware too. > > drivers/tty/serial/8250/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-4.5-rc7.orig/drivers/tty/serial/8250/Kconfig 2016-03-08 09:18:45.610936903 +0100 > +++ linux-4.5-rc7/drivers/tty/serial/8250/Kconfig 2016-03-08 14:26:14.565737750 +0100 > @@ -295,6 +295,7 @@ config SERIAL_8250_EM > config SERIAL_8250_RT288X > bool "Ralink RT288x/RT305x/RT3662/RT3883 serial port support" > depends on SERIAL_8250 > + depends on MIPS || ARCH_TANGO || COMPILE_TEST This seems pretty speculative. I'm concerned that patch v1 was only for MIPS, and now is already needed on at least one ARM platform. Also this won't prevent this type of port at all, but rather will only break its i/o path. Simpler to just remove the option, as I already wrote. Regards, Peter Hurley > default y if MIPS_ALCHEMY || SOC_RT288X || SOC_RT305X || SOC_RT3883 || SOC_MT7620 > help > Selecting this option will add support for the alternate register > > -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
