> On Wed, 9 Mar 2016 08:03:06 +0100, Sean Nyekjær wrote: > > On 2016-03-08 22:18, Jakub Kicinski wrote: > > > On Mon, 7 Mar 2016 10:58:09 -0600, Josh Cartwright wrote: > > >>> I got lost here. Where do we stand here now? > > >> I understood the comment from Kuba to mean that he would be > > >> implementing the disable_irq()/enable_irq() idea above to > > >> fix all the problems with this driver. > > >> > > >> Kuba- did I read that right? > > > I was hoping Sean or someone else would take up this task ;) > > Yes i could try :-) At least i have a working setup with the hardware. > > > > > > It should be a pretty simple patch. > > > > > > Kuba > > I not entirely sure what i have to do... > > - Reenable the ONE_SHOT > > - Disable irq when running in the loop, and enable when returning? > > - Implement threaded irq? > > > > /Sean > > Do not reenable ONE_SHOT. Disable interrupt (disable_irq_nosync()) > in sc16is7xx_irq() and reenable at the end of sc16is7xx_ist(). > I think reenabling at the end of sc16is7xx_ist() is fine since it's a > level triggered IRQ. What do you mean, it's level triggered? How do you know? The irq is requested with either 0 or IRQF_TRIGGER_FALLING for irqflags. I don't see anywhere where it would be configured IRQF_TRIGGER_LOW. Maarten -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
