Re: [PATCH v2] serial-uartlite: Constify uartlite_be/uartlite_le

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Sun, Mar 06, 2016 at 08:14:10PM +0100, Maarten Brock wrote:
> > Made uartlite_be and uartlite_le constants.
> 
> That is what you did, but you did not describe _why_ you are doing this.
> 
> Please fix that up and resend.
> 
> greg k-h
> 

There is no point in instantiating in read-write memory and at run time
initializing a variable when it will never change its value and one also
doesn't intend to ever change it. That's just throwing away resources.

Or did you mean, why I created a second version? Because the first version was
incomplete and generates warnings. These warnings were fixed in 5/5 but not in
the intermediate state that is currently applied in tty-testing. And my 5/5 part
needs work for other reasons.

Please ping me again if you would really like the first answer in the patch
description.

Maarten
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux