Hi, I have a question about the setup of the interrupt for the sc16is7xx and max310x drivers. Both chips seem to use a falling edge triggered interrupt. But in the driver IRQF_TRIGGER_FALLING is only used in flags when there is no dev->of_node. Why is that? Should the interrupt controller already be properly configured from the device tree by another layer (e.g. spi or i2c)? If so, where can I find that? I'm asking because the sc16is7xx (which is based on the max310x) gives me: Mar 1 04:20:15 raspberrypi kernel: [78373.204388] sc16is7xx_port_irq: 154516 callbacks suppressed Mar 1 04:20:15 raspberrypi kernel: [78373.204439] sc16is7xx spi0.1: ttySC0: Unexpected interrupt: 0 That doesn't seem good. I can see that my configuration does have an of_node and thus passes flags=0 to the sc16is7xx_probe() function. It is my suspicion that the interrupt does not get configured and stays at a default low-level-active setting and thus creates a storm of interrupts. Any help is appreciated. Maarten Brock -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html