On 26 February 2016 06:48:09 GMT-05:00, Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> wrote: >This ONESHOT + workqueue combo is something that is not required >because >we have infrastrucure for this kind of things: threaded interrupts. > >This is compile tested only due to -ENODEV. >Now that we that sc16is7xx_irq() is an actual interrupt handler >sc16is7xx_port_irq() could be improved so the former can return >IRQ_NONE >if nothing has been done. > >Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> The reason why this driver is not using threaded irqs is that it already has a kthread to handle other things. Having two threads per port seems like a big waste plus we may need some additional locking between them. Can we just return IRQ_WAKE_THREAD from the handler? IMHO drivers should be perfectly fine to have their own threaded irq setups and core needs to support it. -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
