On Tue, Feb 23, 2016 at 11:54 AM, Romain Izard <romain.izard.pro@xxxxxxxxx> wrote: > As the mctrl_gpio driver can be built as a module, it needs to have its > license specified with MODULE_LICENSE. Otherwise, it cannot access > required symbols exported through EXPORT_SYMBOL_GPL. > > Signed-off-by: Romain Izard <romain.izard.pro@xxxxxxxxx> > --- > drivers/tty/serial/serial_mctrl_gpio.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c > index 226ad23b136c..02147361eaa9 100644 > --- a/drivers/tty/serial/serial_mctrl_gpio.c > +++ b/drivers/tty/serial/serial_mctrl_gpio.c > @@ -20,6 +20,7 @@ > #include <linux/gpio/consumer.h> > #include <linux/termios.h> > #include <linux/serial_core.h> > +#include <linux/module.h> > > #include "serial_mctrl_gpio.h" > > @@ -249,3 +250,5 @@ void mctrl_gpio_disable_ms(struct mctrl_gpios *gpios) > } > } > EXPORT_SYMBOL_GPL(mctrl_gpio_disable_ms); > + > +MODULE_LICENSE("GPL"); Shouldn't it be "GPL v2" instead to match the licensing text in the top of the file? -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html