On Mon, 15 Feb 2016 08:58:53 +0100, Sean Nyekjaer wrote: > Working with RT patches reveals this driver have some spin_lock issues. > > spin_lock moved from sc16is7xx_reg_proc to protect to call to > uart_handle_cts_change as it's the only call that isn't already > protected in serial-core. Sorry but this does not look fine. You are removing all async items from the driver. This works for you because in RT code can sleep with spin locks taken but for upstream it's not acceptable. Did you test this patch with upstream kernel and lockdep enabled? -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html