Re: [PATCH] serial-uartlite: fix missing locking in isr

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> The uartlite driver suffers from missing/duplicate/corrupted character
> data when the interrupt handler runs concurrently with access to the
> device from another cpu. Take the port spinlock to exclude concurrent
> access.

Though I am very glad this is finally fixed in this driver, I don't think it
is the best solution. I (a.k.a. vanmierlo) already had an extensive discussion
about it here:
https://github.com/Xilinx/linux-xlnx/issues/24

I think the spinlock should be taken and released inside the while loop.

I'll try to find some time to send in a patch for this and also for some other
issues from that thread.

Maarten
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux