re: serial: bcm2835: add driver for bcm2835-aux-uart

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Martin Sperl,

The patch bdc5f3009580: "serial: bcm2835: add driver for
bcm2835-aux-uart" from Jan 17, 2016, leads to the following static
checker warning:

	drivers/tty/serial/8250/8250_bcm2835aux.c:63 bcm2835aux_serial_probe()
	warn: unsigned 'data->uart.port.irq' is never less than zero.

drivers/tty/serial/8250/8250_bcm2835aux.c
    60  
    61          /* get the interrupt */
    62          data->uart.port.irq = platform_get_irq(pdev, 0);
    63          if (data->uart.port.irq < 0) {
                    ^^^^^^^^^^^^^^^^^^^^^^^
signedness bug.

    64                  dev_err(&pdev->dev, "irq not found - %i",
    65                          data->uart.port.irq);
    66                  return data->uart.port.irq;
    67          }
    68  

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux