On 01/21/2016, 05:52 AM, Fugang Duan wrote:
> The vt CONSOLE number is 1 ~ 63, and users CONSOLE is 63
No, users CONSOLE is 1 ~ 63 too. Actually both are 0 ~ 62, right?
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
> @@ -762,14 +762,14 @@ int vc_allocate(unsigned int currcons) /* return 0 on success */
> {
> WARN_CONSOLE_UNLOCKED();
>
> - if (currcons >= MAX_NR_CONSOLES)
> + if (currcons > MAX_NR_CONSOLES)
> return -ENXIO;
> if (!vc_cons[currcons].d) {
!vc_cons[63].d would be -EHOLE. Hence NACK.
> struct vc_data *vc;
> struct vt_notifier_param param;
>
> /* prevent users from taking too much memory */
> - if (currcons >= MAX_NR_USER_CONSOLES && !capable(CAP_SYS_RESOURCE))
> + if (currcons == MAX_NR_USER_CONSOLES && !capable(CAP_SYS_RESOURCE))
> return -EPERM;
It's like this since 1.1.54.
I believe we can drop it along with MAX_NR_USER_CONSOLES macro.
thanks,
--
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
