> The architecture of 8250_pci.c is good for PCIE device with 8250 > compatible serial ports. We want to implement all functions of > F81504/508/512, but it'll make 8250_pci.c bloated and complex if we > implement GPIOLIB in 8250_pci.c Your device is multi-function. Create an MFD driver for it. Make the 8250 driver bind to the MFD, and provide your own baud rate methods within the standard 8250 layer Implement the GPIO lines in a GPIO driver that also binds to the MFD and lives in drivers/gpio All the needed pieces already exist to implement it cleanly this way without duplicating a ton of code. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html