Hi Russell, On 01/04/2016 09:10 PM, Russell King - ARM Linux wrote: > On Mon, Jan 04, 2016 at 07:22:06PM +0100, Martin Fuzzey wrote: >> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c >> index 016e4be..16a551b 100644 >> --- a/drivers/tty/serial/imx.c >> +++ b/drivers/tty/serial/imx.c >> @@ -2071,13 +2071,13 @@ static int imx_serial_port_suspend_noirq(struct device *dev) >> struct imx_port *sport = platform_get_drvdata(pdev); >> int ret; >> >> - ret = clk_enable(sport->clk_ipg); >> + ret = clk_prepare_enable(sport->clk_ipg); >> if (ret) >> return ret; >> >> serial_imx_save_context(sport); >> >> - clk_disable(sport->clk_ipg); >> + clk_disable_unprepare(sport->clk_ipg); > > NAK. If this is _noirq, then it's a context which can't sleep. Therefore, > calling functions that do sleep is not permitted. That's not not exactly correct. At suspend_noirq time only SPI(device's) IRQs are disabled while syscore (systimers, scheduler, main irq controllers, nonboot cpus) is still active. -- regards, -grygorii -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
