On Sun, Dec 27, 2015 at 12:46 PM, Geliang Tang <geliangtang@xxxxxxx> wrote: > Use to_pci_dev() instead of open-coding it. > > Signed-off-by: Geliang Tang <geliangtang@xxxxxxx> > --- > drivers/tty/serial/8250/8250_pci.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c > index 4097f3f..afdd2c67 100644 > --- a/drivers/tty/serial/8250/8250_pci.c > +++ b/drivers/tty/serial/8250/8250_pci.c > @@ -1538,8 +1538,7 @@ static int pci_fintek_rs485_config(struct uart_port *port, > { > u8 setting; > u8 *index = (u8 *) port->private_data; > - struct pci_dev *pci_dev = container_of(port->dev, struct pci_dev, > - dev); > + struct pci_dev *pci_dev = to_pci_dev(port->dev); I would make it first line in this block. Otherwise, Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > pci_read_config_byte(pci_dev, 0x40 + 8 * *index + 7, &setting); > -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html