On Fri, Nov 13, 2015 at 08:34:54AM -0500, Rob Groner wrote: > On Fri, 2015-11-13 at 13:07 +0530, Sudip Mukherjee wrote: > > On Thu, Nov 12, 2015 at 02:49:29PM -0500, Rob Groner wrote: > > > On Thu, 2015-11-12 at 11:36 -0800, Greg KH wrote: > > > > On Thu, Nov 12, 2015 at 02:26:12PM -0500, Rob Groner wrote: > > > > > On Thu, 2015-11-12 at 09:52 -0800, Greg KH wrote: > > > > > > On Thu, Nov 12, 2015 at 03:16:00PM +0000, Rob Groner wrote: > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > From: Greg KH [mailto:greg@xxxxxxxxx] > > > > > > > > Sent: Thursday, November 12, 2015 9:51 AM > > > > > > > > To: Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx> > > > > > > > > Cc: Rob Groner <rgroner@xxxxxxx> > > > > > > > > Subject: Re: [PATCH] 8250_pci: Prevent Exar/RTD Boards from binding. > > > > > > > > > > > > > > > > On Thu, Nov 12, 2015 at 07:24:06PM +0530, Sudip Mukherjee wrote: <snip> > > And Rob, your initial patch (not binding to these devices) will force > > all users to use the out of tree driver. Your device was added to 8250 > > by Soeren Grunewald and I guess he wants to use an upsteam driver for > > his device. > > My patch (unless I did it wrong) would only force users of RTD-produced > boards from using the out of tree driver. Soeren included support for > all boards that had the Exar chipset as the device ID (which includes > ours). I tried to exclude only those boards that have an Exar Device > ID, but an RTD sub-vendor device ID. Yes, i saw that. But I can assume there will be users of your board who might like to use the upstream driver and they may not have any use of reconfiguring. Anyway, this will be Greg's decision. > > > And your driver does not say anything about how you are reconfiguing the > > board to RS485. There is another pci card Fintek who are also doing a > > reconfiguration. Maybe you can have a look at pci_fintek_rs485_config() > > in 8250_pci.c file. If you can post the code to reconfigure the board, > > then i think these custom ioctl to reconfigure the board will not be > > needed. > > The utility for reconfiguring the board is quite lengthy. Here is a > link to the package if that helps, or I can post it if you want. > > http://www.rtd.com/software/UM/SERX5330/SER25330_Linux_v01.00.00.tar.gz Its not that lengthy. :) So it turns out that to change it to RS485 mode you are writing SETTINGS_PORT_MODE_RS485 to EEPROM_OFFSET_PORT_CONFIG register using your custom ioctl based on your port index. I think a similar function like pci_fintek_rs485_config() can be made which will respond to TIOCSRS485 ioctl command. But I dont know how to manage SETTINGS_PORT_MODE_RS422 and SETTINGS_PORT_MODE_RS485_RTS_INV. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
