On Thu, Nov 05, 2015 at 10:06:22AM +0100, Florian Achleitner wrote: > We found that our sc16is7xx on spi reported a TX fifo free space value > (TXLVL_REG) of 255 ocassionally, which is obviously wrong, with a > 64 byte fifo (and caused a buffer overrun, which is fixed separately). > > To trigger this, a large write to the tty is sufficient. The fifo fills, > TXLVL_REG reads zero, but the handle_tx function does a zero-data-length > write to the TX fifo anyways through sc16is7xx_fifo_write. The next > TXLVL_REG read then yields 255, for unknown reasons. A subsequent read > is ok. > > Prevent zero-data-length writes if the TX fifo is full, because they are > pointless, and because they trigger wrong TXLVL read-outs. > > Signed-off-by: Florian Achleitner <achleitner.florian@xxxxxxxxxxx> > --- > > checkpatch.pl'ed, reformated, slightly reworded. Any reason you aren't cc:ing the serial maintainer so that these patches can be taken? scripts/get_maintainer.pl is your friend :) And I'm totally lost with all of the different versions happening here, can you resend the whole series please? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
